kheina-com / Blue-Blocker

Blocks all Twitter Blue verified users on twitter.com
Mozilla Public License 2.0
337 stars 28 forks source link

0.4.3 #312

Closed rougetimelord closed 1 month ago

rougetimelord commented 1 month ago

Collecting a few PRs together that have all been assigned the same version string, so that it's less confusing!

Changes:

Todo:

cooljeanius commented 1 month ago

I think we might want to make sure that the changes from browser-actions/release-firefox-addon#12 get included before merging this...

cooljeanius commented 1 month ago

I think we might want to make sure that the changes from browser-actions/release-firefox-addon#12 get included before merging this...

Also I wonder if we could get #296 in as well?

rougetimelord commented 1 month ago

I think we might want to make sure that the changes from browser-actions/release-firefox-addon#12 get included before merging this...

Also I wonder if we could get #296 in as well?

We should probably do that lol! I didn't bundle it in since #296 isn't a code change, but it should definitely get merged with (or before) we release this version

Edit: I merged it into this

rougetimelord commented 1 month ago

Also @kheina, I'm pretty sure that the AMO external API doesn't have any endpoints to update a privacy policy :((( the only endpoint I could find gets the privacy policy

We shouldn't need to update it, so I don't think it's super necessary to be able to automate that step. It also seems pretty common to not update the privacy policy on the addon page every time, and the privacy policy I wrote tells users that the version on the addon page may not be the most up to date.

I did open an issue on the Mozilla addons repo about this too, so we will see.

Edit: Mozilla says that they'll get an API method up and running in their 8/8 release :)) Then it should be as easy as adding a workflow to upload to AMO anytime the privacy policy file is touched.

rougetimelord commented 1 month ago

This is getting kinda big; let's try to save any further changes for a later release

Yup that was the last thing lol

rougetimelord commented 1 month ago

Mozilla says that they'll get an API method up and running in their 8/8 release :)) Then it should be as easy as adding a workflow to upload to AMO anytime the privacy policy file is touched.

PR merged! https://github.com/mozilla/addons-server/pull/22522

cooljeanius commented 1 month ago

Mozilla says that they'll get an API method up and running in their 8/8 release :)) Then it should be as easy as adding a workflow to upload to AMO anytime the privacy policy file is touched.

PR merged! mozilla/addons-server#22522

...well ok, would you like to get this into this release as well? Or would that be too much?

kheina commented 1 month ago

I'll do some work on this tonight and try to get it out. let's wait on the privacy policy stuff, that can go out without a release

cooljeanius commented 1 month ago

@kheina I think you still need to re-approve, since #315 isn't merged yet...

kheina commented 1 month ago

@kheina I think you still need to re-approve, since #315 isn't merged yet...

I didn't realize I could dismiss my own review