khenriks / mp3fs

FUSE-based transcoding filesystem from FLAC to MP3
http://khenriks.github.io/mp3fs/
GNU General Public License v3.0
384 stars 46 forks source link

mp3fs does not build with FLAC 1.3.0 (on FreeBSD) #12

Closed sterum closed 10 years ago

sterum commented 11 years ago

Just for information.

Since the update of FLAC to version 1.3.0 mp3fs does not build on FreeBSD because there is a missing header in transcode.c. I don't know if it builds on linux or windows. Perhaps you could have a look at this.

here is a solution

Begin diff

--- src/transcode.c 2012-05-01 22:12:48.000000000 +0200
+++ src/transcode.c 2013-06-15 19:19:13.000000000 +0200
@@ -21,6 +21,7 @@

 #define _GNU_SOURCE

+#include <inttypes.h>
 #include <stdio.h>
 #include <string.h>
 #include <unistd.h>

End diff

I have sent a problem report to the FreeBSD project. When it is commited mp3fs should build successfully.

khenriks commented 11 years ago

I'm surprised that's all that's needed for FLAC 1.3.0. Everything seems to work fine after that change?

The code just underwent a major rewrite that may have addressed this issue anyway in passing. When I make the next release, you can see if it seems to have helped.

(I also fixed your bug text above. The include statements appeared empty before. When including code snippets in the future, be careful to use the proper syntax for code according to GitHub Flavored Markdown.)

sterum commented 11 years ago

Well, i have not tested very much. The only thing i have tried was

mp3fs $FLACDIR $MP3DIR

and this worked as expected. (and of course, playback works too)

khenriks commented 10 years ago

The new release is out. Can you check it again?

sterum commented 10 years ago

With the new release, ./configure fails. I will open a new issue.

khenriks commented 10 years ago

This seems to be now fixed in the latest release.