khenriks / mp3fs

FUSE-based transcoding filesystem from FLAC to MP3
http://khenriks.github.io/mp3fs/
GNU General Public License v3.0
382 stars 46 forks source link

Added an Ogg Vorbis decoder to mp3fs #40

Closed ghost closed 9 years ago

ghost commented 9 years ago

Hello, in order to get a unified view of my flac and ogg music collection, I've added an Ogg Vorbis decoder class and integrated it into the build system. Please feel free to comment about it and, at your choice, incorporate it into your repo.

Kind regards, Thomas Schwarzenberger

khenriks commented 9 years ago

Sorry for the wait. I'm catching up now on things that I've neglected. I appreciate your contribution.

The indentation and line length don't match the conventions used elsewhere in the code, and I'd like that to be more consistent. I'd also appreciate having tests added for this functionality. Are you interested in working further on this to respond to comments, or is this more of a code contribution that I can modify as I want to integrate it?

ghost commented 9 years ago

Hello, thanks for your appreciation! Please feel free to streamline these changes into the way you structure your code. The Ogg Vorbis funtionality is working perfectly for me, but currently, it's hard for me to find spare time besides my profession.

I should be able to work on your comments as long as this is not too time critical. Test coverage possibly is a bigger problem.

khenriks commented 9 years ago

I've just added a couple comments to resolve, and test coverage can come later if necessary (as long as the existing tests still pass with the new code).

ghost commented 9 years ago

Ogg Vorbis picture handling is working for valid METADATA_BLOCK_PICTURE.

ghost commented 9 years ago

Hi there, maybe you'd like to have a look at the progress here. By now, the Ogg Vorbis part should be complete, inclusive picture handling.

khenriks commented 9 years ago

Thanks so much! Sorry for the delay, and I appreciate your contribution.

bluemoehre commented 9 years ago

Thanks a lot! I will update as soon as possible =)

intrigeri commented 6 years ago

Any chance a new release is published? I'd love to use this feature once this reaches Debian :)