search

khenriks / mp3fs

FUSE-based transcoding filesystem from FLAC to MP3
http://khenriks.github.io/mp3fs/
GNU General Public License v3.0
382 stars 46 forks source link

Substantial improvements on audio quality plus test cases for the Ogg Vorbis decoder #45

Closed ghost closed 6 years ago

ghost commented 8 years ago

Hi, there are some silly mistakes I'd like to have corrected. The most prominent and now fixed effectively rendered the transcoded Ogg Vorbis audio mono... As I've said, now fixed. Furthermore, there are some test cases for the Ogg Vorbis decoder now, ripped off the existing Flac tests.

ghost commented 8 years ago

Hello khenriks,

this pull request stabilizes the support for Ogg Vorbis, adds common automated tests and fixes the automated build test (f___ Ubuntu wouldn't ship with libb64). So please consider it a merge candidate.

Yours kindly, quarterpounder

khenriks commented 7 years ago

Hi quarterpounder,

After a bit of a hiatus, I've been working on mp3fs more, and I had actually completely forgotten about this pull request. I'd been working on investigating and fixing essentially the same thing.

For the testing, I wanted to take a slightly different approach, but since you've done the work to fix the Vorbis decoder, I'd like to accept that part of the request.

Can you separate out just the changes to vorbis_decoder.cc in this request? If you can also squash the changes into a single commit, that would be great.

Regards, khenriks

ghost commented 7 years ago

Hi khenriks,

a quick git diff gave me this: changes-from-#40.zip

Maybe, this is helpful.

Cheers, quarterpounder

khenriks commented 7 years ago

I can grab the diffs myself, I just thought I'd make it a proper pull request so it had your name attached and whatnot. If it's not important to you though, I'll just apply the diffs for that file directly then.

khenriks commented 6 years ago

These improvements have already been applied separately at master, so closing.