Closed salnajjar closed 5 years ago
The best way to approach this is to come up with a test case. What is unique about the samba access pattern? The first thing that jumps out at me are the failed attempts to LOOKUP /mp3fs. Is samba doing that? Or is another process doing so? Maybe this is a bug that shows up with two processes accessing the fuse filesystem.
If you can think of another process that is doing the /mp3fs lookups, then stop that process and see if the samba access starts working. That would narrow down what is going on.
I believe this is a problem with the Vampire Weekend/Vampire Weekend/03 A-Punk.flac file. Notice all of the errors from FLAC right before the segfault. Is there a way you can share that file with me? It seems I'm not properly handling errors.
Hi, I have the same issue and added the file. I have this problem a lot. I was pointed here by an answer to my question here.
On my clients I use Lubuntu 18.04 and 18.10. I did however successfully copy this file (and others) the last time with Lubuntu 16.04. Not sure if this makes sense.
I was not able to compress my flac, so I made three files with ZIP that had the names
file.zip.001 file.zip.002 file.zip.003
I had to strip the 000-part to be able to upload it as a supported file format (ZIP). Please remove the 000-part from the front and put it at the end, as seen above.
I'm trying to reproduce this, and I'm having trouble, even with the file you provided. Can you please try the following:
catchsegv mp3fs -d <args>
where you replace <args>
with appropriate arguments.Thanks!
Aha! I found the issue, it has to do with concurrent reads from the same file, and mp3fs not being properly thread-safe. I'll look into the issue some more.
Do you still need something? I think it still works well with Lubuntu 16.04.05 LTS on an ASUS F205 laptop (Intel Atom). I have issues on my Shuttle Barebone PC with a powerfull CPU. But even there I was able to use it withou problems under Lubuntu 16.04 or 16.10. The change in behaviour came with my upgrade to 18.04 I guess. Maybe this is related to the way CIFS works now.
I don't need anything else, I'm able to reproduce the issue, thanks. I just need to implement a fix now.
This should now be resolved with the latest commit pushed to master.
mp3fs is working perfectly on accessing and copying the files via the local server, however, if I share the mp3fs directory via samba, the moment I try to access one of the mp3 files mp3fs segfaults on me requiring samba to be restarted and the mp3fs mount point to be unmounted and mounted again.
Mounting with the command:
mp3fs -o allow_other -b 256 --quality=2 -d /data/music/flac /data/music/mp3
Produces a clean mount:
But as soon as I try to access a file via the samba share I get:
dmesg shows:
I've tried with the 0.9.1 release from source and via a git clone of the repository with the same results.