khenriks / mp3fs

FUSE-based transcoding filesystem from FLAC to MP3
http://khenriks.github.io/mp3fs/
GNU General Public License v3.0
382 stars 46 forks source link

Make the manpage generation reproducible. #59

Closed lamby closed 4 years ago

lamby commented 5 years ago

Whilst working on the Reproducible Builds effort, we noticed that mp3fs could not be built reproducibly as it uses a locale, timezone and current-time-of-date header in the generated manpage.

This patch ensures that the output is consistent regardless of the build user's location, or by the current time by utilising the SOURCE_DATE_EPOCH environment variable.

lamby commented 5 years ago

Let me know if you have any questions or queries regarding this patch - happy to help!

lamby commented 5 years ago

(Updated patch.)

khenriks commented 4 years ago

Thanks for your contribution, and sorry that I've sat on this for so long. I appreciate your goal here of making the build reproducible. There are actually some changes to how I would deal with differing date implementations (autoconf can make this more convenient). However, I'm just going to accept this as-is and fix that in a follow-up. Thanks!