search

khenriks / mp3fs

FUSE-based transcoding filesystem from FLAC to MP3
http://khenriks.github.io/mp3fs/
GNU General Public License v3.0
382 stars 46 forks source link

Added auto_cache flag to example, due to much better performance #61

Closed bluemoehre closed 3 years ago

bluemoehre commented 5 years ago

The auto_cache flag is improving performance a lot, because it will keep already encoded files within the cache for a while. When using mp3fs as backend for a web media server it will speed up seeking an re-playing last played songs. Also via Samba I noticed some improvements. I think it is worth adding it!

auto_cache This option is an alternative to kernel_cache. Instead of unconditionally keeping cached data, the cached data is invalidated on open(2) if the modification time or the size of the file has changed since it was last opened.

More information: http://man7.org/linux/man-pages/man8/mount.fuse.8.html

bluemoehre commented 4 years ago

Hey @khenriks this PR has been a while ago - is there any reason why not using it? (it's been running smoothly for me ever since =)

khenriks commented 3 years ago

It doesn't seem like auto_cache actually enables any caching, based on my reading of the manual pages. It triggers flushing the cache based on certain criteria, but the caching still happens either way. I think I'd prefer to leave this option out because people might get the wrong idea about what it does. Sorry about that.