search

khenriks / mp3fs

FUSE-based transcoding filesystem from FLAC to MP3
http://khenriks.github.io/mp3fs/
GNU General Public License v3.0
382 stars 46 forks source link

Sort by file name #7

Closed MihailZenkov closed 6 years ago

MihailZenkov commented 11 years ago

Simple mp3 players don't sort files by name. They just show track in order as files has written on disk.

Players that have sort files by name should show track list slightly faster with this patch.

khenriks commented 11 years ago

I have a comment and a question.

First, in the function cleanup you need to free not just namelist, but also each individual member of namelist. Otherwise it leaks memory.

Second, can you clarify which "simple mp3 players" you're referring to? Note that the same issue would be encountered when playing the FLAC files that are converted by mp3fs or even when playing ordinary mp3's from an ordinary directory. The order stored on disk is essentially arbitrary and no player should rely upon it.

MihailZenkov commented 11 years ago

I have tested Ritmix RF-3200 and Ritmix RF-3300 (other brand name "Archos Key"). I suppose many other low-end mp3 players have same problem.

Note that the same issue would be encountered when playing the FLAC files that are converted by mp3fs or even when playing ordinary mp3's from an ordinary directory. The order stored on disk is essentially arbitrary and no player should rely upon it.

You right, but these players show files as is stored on disk in both case (with and without conversion). It very annoying. I use mp3fs (with patch) for these players all time to prevent this.