search

khepin / KhepinYamlFixturesBundle

Easy loading of fixtures defined in YAML files for Symfony2 and Doctrine2
MIT License
58 stars 42 forks source link

Add support for application kernels which are not named AppKernel #48

Closed dsbaars closed 10 years ago

dsbaars commented 10 years ago

Cleaner solution than #33, because it checks on implementation of the KernelInterface.

I also adjusted the tests for this and fixed some MongoDB tests which assumed the return of a cursor, when it was an array. Also, I improved adherence to the PHP coding standard for some lines of code.

khepin commented 10 years ago

Why all the format changes? It makes it really difficult to find out where are the actual changes to the code and review them.

Also it seems you didn't add a test for your use case.

dsbaars commented 10 years ago

The format changes makes this bundle adhere to the PHP coding standards (http://symfony.com/doc/2.3/contributing/code/standards.html)

Furthermore, the testing code only needed to be modified. See: https://github.com/dsbaars/KhepinYamlFixturesBundle/blob/a13260ccdaada0aa461b7cf2fe8e44b05181d61d/tests/Khepin/Tests/YamlFixtureTest.php#L26

khepin commented 10 years ago

Alright, thanks for clarification. Sorry for the delay, I am moving to a new country, lots of things to do. I'm adding you to the repo. You'll be able to publish a version if needed.