The first widget should be removed from the widget tree once the animation is finished

kherel / animated_theme_switcher

Flutter animated theme switcher

https://pub.dev/packages/animated_theme_switcher

MIT License

278 stars 28 forks source link

The first widget should be removed from the widget tree once the animation is finished #69

Closed NamanShergill closed 9 months ago

NamanShergill commented 9 months ago

https://github.com/kherel/animated_theme_switcher/blob/9b659e593fa5dd21c0d3b5a725dbaa20d665736f/lib/src/theme_switching_area.dart#L32-L35

Not removing it from the widget tree is not the performant approach, plus, the old widget is still visible if any scroll views are involved with a transparent background.

NamanShergill commented 9 months ago

Opened a PR to not show the stack once the switching animation is finished.