Closed cestella closed 8 months ago
Awesome work, thank you! It's 12 am here, I will review everything tomorrow and merge if everything is fine!
Thanks again @cestella great work! Just some notes:
model.home
to target/models
if it's not set. Since the model is downloaded anyway, this would simplify getting started.q2_k
instead of q5_k_s
should suffice, right? This would reduce the necessary download size.Absolutely!
model.home
default to target/models
you might want to just create a models
directory at the top level and make it that. mvn clean
will delete the whole target directory, so you will end up redownloading the model a lot.q2_k
. I did notice that the unit tests may have been slightly different when I tried other quants.
This PR does the following:
After this PR, you can run the integration tests via maven like so:
mvn verify -Dmodel.home=$HOME/llm/models
Note:$HOME/llm/models
is the model home directory. This is where the integration test model will be stored.Examples
In addition to refactoring the unit test, I reran the examples. I modified the examples to be able to be run via maven:
examples.GrammarExample
This looks roughly like what I see if I run the same example from main:
examples.InfillExample
With the new code I see:
With master I see:
examples.MainExample
I made a couple of modifications to both the old version and the new version to compare:
User:
so it actually completes the statementWith this PR I see:
With master I see: