search

khevamann / rn-responsive-styles

Responsive styles for react-native and react-native-web
MIT License
39 stars 3 forks source link

Add const for screen width =< 540 as EXTRA_SMALL_DEVICE #1

Closed chrda81 closed 2 years ago

chrda81 commented 2 years ago

For smaller devices an extra helper constant for DEVICE_SIZES is useful.

khevamann commented 2 years ago

This looks good, I will go ahead and merge. I plan to add support for dynamic breakpoints soon. But this is good to have until then. Would you like me to create an NPM release for this now or wait? If you are using it now I can create the release. If not I will wait until there are a few more changes.

chrda81 commented 2 years ago

Hi,

thanks for your very helpful package and for merging my code. You don’t have to make a release just for this, I can wait a little bit longer. In the meantime I use a self-made patch to include this code.

Thanks, Sky

On 5. Feb 2022, at 03:26, Kheva Mann @.***> wrote:

This looks good, I will go ahead and merge. I plan to add support for dynamic breakpoints soon. But this is good to have until then. Would you like me to create an NPM release for this now or wait? If you are using it now I can create the release. If not I will wait until there are a few more changes.

— Reply to this email directly, view it on GitHub https://github.com/khevamann/rn-responsive-styles/pull/1#issuecomment-1030502962, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIYMMADOBHFN5MKSSSXP3TLUZSDG3ANCNFSM5NS5G2CQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.