search

khevamann / rn-responsive-styles

Responsive styles for react-native and react-native-web
MIT License
40 stars 3 forks source link

Added options for simple media queries #3

Closed khevamann closed 2 years ago

khevamann commented 2 years ago

This PR adds the ability to apply styles to multiple device sizes at once using minSize() and maxSize. See the README for more details on how this works.

@EthanHermsey how does this look to you?

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@200a028). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage        ?   95.89%           
=======================================
  Files           ?        6           
  Lines           ?       73           
  Branches        ?        7           
=======================================
  Hits            ?       70           
  Misses          ?        3           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 200a028...1458a7f. Read the comment docs.

EthanHermsey commented 2 years ago

Wow I like that! The idea of the min/maxsize and how you implemented it. Looks efficient, nice! :)

khevamann commented 2 years ago

Cool, I'll get this merged. Thanks for bringing the issue up and taking a stab at it first! @EthanHermsey