khia / exlager

Elixir binding for lager
Apache License 2.0
66 stars 36 forks source link

Lager setting should be mentioned in README #12

Closed mprymek closed 10 years ago

mprymek commented 10 years ago

Hello, I consider Exlager really nice but (if I didn't miss something) in the README there is not mentioned one crucial moment - underlying Lager has it's own default setting which is not affected by Exlager settings. It took me some time to realize this...

For instance if you set elixirc_options: [exlager_level: :debug, exlager_truncation_size: 8096] you still get no debug messages in the console because lager has default {handlers, [{lager_console_backend, info}, ... (see https://github.com/basho/lager/blob/master/src/lager.app.src )

IMHO there should be some warning in the README that you must override the default with app.config, explicitly use lager:set_loglevel/2 or such... and ideally Exlager should have some way to set Lager's options.

P.S. thank you very much for your work on Exlager!

khia commented 10 years ago

Addressed in 779a7535