search

khiav223577 / deep_pluck

Allow you to pluck attributes from nested associations without loading a bunch of records.
MIT License
460 stars 14 forks source link

Compatibility with Rails 6.1.1 #39

Closed klausbadelt closed 3 years ago

klausbadelt commented 3 years ago
  1. upgrade to latest pluck_all for Rails 6.1 compatibility
  2. ignore test code in coverage

Fixes #38

@khiav223577 IMHO only live code should be included in coverage, not tests. Fixed this here, but if you feel otherwise or don't like mixing both issues into one PR, I'm happy to move this out.

khiav223577 commented 3 years ago

IMHO only live code should be included in coverage, not tests. Fixed this here, but if you feel otherwise or don't like mixing both issues into one PR, I'm happy to move this out.

Thanks. I did not notice test files were included in coverage. I have to find time to fix the issue in many of other projects of mine. :sweat_smile:

I would prefer separating them into different PRs in that I use github-changes to generate a changelog based on merged pull requests. (Note that your modification to the CHANGELOG may be overwritten by the title of this PR because of this.) Please move it out, and I'll be happy to merge them and release a new version :)

klausbadelt commented 3 years ago

@khiav223577 moved out test coverage, and since Rails 6.1.1 come out meanwhile, I threw that in too.

khiav223577 commented 3 years ago

Thanks for you contribution. Just release version 1.1.5