khimaros / smart-auto-move

Smart Auto Move learns the size and position of your application windows and restores them to the correct place on subsequent launches. Supports Wayland.
https://extensions.gnome.org/extension/4736/smart-auto-move/
GNU General Public License v3.0
79 stars 4 forks source link

Gnome 45 support? #44

Closed ionutbortis closed 2 months ago

ionutbortis commented 10 months ago

Hi and thank you for this awesome extension!

Honestly, I don't think I could go back to gnome not remembering window sizes and positions :sweat_smile:

Are there any plans in supporting the next Gnome Shell version, 45? I'm asking this because the gnome shell devs kinda broke all the extensions with this new release...

There is no backwards compatibility with previous versions and not all the previously exposed objects are available anymore, due to the ecma script modules transition :worried: => https://gjs.guide/extensions/upgrading/gnome-shell-45.html

My extension doesn't have a large codebase so I was able to properly adapt it for 45 in a timely manner.

Tyrbiter commented 9 months ago

I'd really appreciate having S-A-M back again in GNOME 45, it's not until you don't have it that you realise its value.

ionutbortis commented 7 months ago

@khimaros I created #45 PR for the Gnome 45 support. Let me know what you think!

@Tyrbiter @Bytezz Maybe you can also help with testing, these changes seem to run fine on my machine, but other Gnome 45 installs won't hurt, I guess :sweat_smile:

Thanks, Ionut

ionutbortis commented 7 months ago

I also attached here the build for the gnome 45 port. For testing and maybe for submission to EGO if you want to skip a Gnome 45 vm install. Thanks!

smart-auto-move@khimaros.com.shell-extension.zip

Tyrbiter commented 7 months ago

I have substituted the files from this zip file instead of the originals, so far it appears to work well.

A very welcome offering, it's such a useful extension.

Should have said this is GNOME 45 on Fedora 39 using Wayland.

Bytezz commented 7 months ago

Since I'm still on Gnome 44, I tried it on Gnome OS Nightly inside Gnome Boxes and it works.

SAM on Gnome OS Nightly

ionutbortis commented 7 months ago

@Bytezz @Tyrbiter Nice, thanks for testing it out!

I'm not sure if it's a bug or a feature, but I love this way of handling terminals via SAM. First one opens snapped to half right, the next ones snapped to half left :star_struck:

Screencast from 2023-11-22 18-23-26.webm

KataFF commented 5 months ago

Smart Auto Move works on up-to-date Manjaro/Arch no problem on GNOME 45.3., Wayland session, and has worked at least since 45.1 and three months back. Perhaps the issue can be closed, especially if other popular distros get tested working (Debian Bookworm, Ubuntu, Fedora etc.)?

ionutbortis commented 5 months ago

Smart Auto Move works on up-to-date Manjaro/Arch no problem on GNOME 45.3., Wayland session, and has worked at least since 45.1 and three months back. Perhaps the issue can be closed, especially if other popular distros get tested working (Debian Bookworm, Ubuntu, Fedora etc.)?

That's weird. There isn't any official release for Gnome 45. Maybe someone bundled the modified version to an AUR package.

@khimaros previously said that he's on Debian testing and that distro is still on 44.8. I was given the impression that he will properly update the extension to 45 when Debian testing will also get to gnome shell 45.

khimaros commented 2 months ago

i have just tested this with GnomeOS nightly and can confirm that basic functionality is there. i'm going to look at the linked PR shortly and merge.

thank you @ionutbortis for your work on this and for your (extreme) patience.

khimaros commented 2 months ago

fixed by #45 -- thank you again @ionutbortis

release should reach EGO shortly, pending their review.

khimaros commented 2 months ago

reopening until this is available on EGO.

SebTM commented 2 months ago

Hey, sorry for my missing context but what is EGO? Could you also draft a release so I can update the extension for NixOS? (https://search.nixos.org/packages?query=smart-auto-move&channel=unstable)

teatwig commented 2 months ago

EGO = extensions.gnome.org

khimaros commented 2 months ago

@SebTM coincidentally, i'm looking at using a NixOS virtual machine to automate testing on multiple versions of GNOME. do you have a configuration.nix which could run multiple versions of GNOME in the same NixOS install? i will manually push the smart-auto-move extension to the VM from the host so i won't be using your extension package.

khimaros commented 2 months ago

this is the version which should be making it's way to EGO (pending approval)

smart-auto-move@khimaros.com.shell-extension.zip

did some basic testing with GNOME OS nightly (46)

khimaros commented 2 months ago

published to extensions.gnome.org and tagged as release v25

https://github.com/khimaros/smart-auto-move/releases/tag/v25

SebTM commented 2 months ago

i'm looking at using a NixOS virtual machine to automate testing on multiple versions of GNOME. do you have a configuration.nix which could run multiple versions of GNOME in the same NixOS install?

Hey, sorry for the delay - I think it's possible but due to NixOS / Nixpkgs not maintaining multiple gnome-versions in a package-set you would need to construct a flake with different nixpkgs-inputs and build vms of them with the corresponding versions I would say. Maybe join the NixOS Gnome channel on matrix and ask for support there - I'm sure people are willing to help setup a nix-based environment to automate/simplify maintenance as this could be adopted by other extensions later :)

https://matrix.to/#/#gnome:nixos.org

SebTM commented 2 months ago

published to extensions.gnome.org and tagged as release v25

Share the info in the channel mentioned above maybe it can be included in the upcoming gnome-46 merge still 🙏🏻

SebTM commented 2 months ago

FYI: NixOS - v26 included in https://github.com/NixOS/nixpkgs/pull/306197