search

khimaros / smart-auto-move

Smart Auto Move learns the size and position of your application windows and restores them to the correct place on subsequent launches. Supports Wayland.
https://extensions.gnome.org/extension/4736/smart-auto-move/
GNU General Public License v3.0
79 stars 4 forks source link

Gnome 45 support #45

Closed ionutbortis closed 2 months ago

ionutbortis commented 7 months ago

Hi!

Since I recently upgraded to 45 I thought I could lend a hand and port your extension as well. It seems to work fine on my machine.

I tried to keep the code changes minimal but FYI, the guys reviewing gnome extensions have stricter guidelines now. If they will reject this submission, please let me know and I'll do my best to make the necessary changes.

Also, do you plan on maintaining this extension in the future?

If not, please think about an ownership transfer. We have a github organization for unmaintained gnome extensions, Extensions Valhalla. So far we manage only one extension, but if you're too busy, we would gladly accept your extension. The goal is to provide minimum support for new gnome releases.

Thanks!

IBBoard commented 7 months ago

Only just started using it, but it seems to be working for me 🙂 Thanks!

khimaros commented 7 months ago

@ionutbortis thank you for this pull request. looks reasonable overall.

i will try to get a GNOME 45 environment set up so that i can test this in the coming days.

as of now, i'm still interested in maintaining this project. however,, release cadence is likely to continue tracking with debian testing, as that's what i use on all of my devices.

ionutbortis commented 7 months ago

@khimaros

Cool, glad to hear that you didn't abandon this project!

I see that debian testing has gnome-shell 44.5, only the experimental branch has the latest 45... Maybe using a vm for minimum code changes when new gnome versions pop out?

Personally, I use a Fedora Rawhide vm in Virtual Box that I update from time to time. That seems to work fine, so far.

ShaunTheSalvo commented 7 months ago

I just gave this a test, and it seems to be working fine! I installed it using ionutbortis's instructions at https://extensions.gnome.org/extension/4736/smart-auto-move/.

Installed, rebooted, activated the extension and it worked. Looking good so far. I'll do some more testing over the next few days. Running on an Arch Linux VM in Gnome Boxes.

sol2070 commented 7 months ago

I also tested. It's working for me, on Gnome Shell 45.1 (Arch).

nkudriavtsev commented 7 months ago

Thank you! Works.

Tyrbiter commented 6 months ago

Starting to see this failing to find some app windows in the Saved Windows tab, can't find where the selected window details are stored either.

KataFF commented 5 months ago

Works as advertised on GNOME Shell 45.3 on Manjaro: image

khimaros commented 5 months ago

@KataFF to clarify, are you testing with the modified version of smart-auto-move from this PR or are you using the one from the GNOME extension store?

Rammani28 commented 4 months ago

What should I do to enable this extension in my system? image

ionutbortis commented 4 months ago

@Rammani28

Unfortunately, the owner of the extension said that he's using debian testing which is still on gnome shell 44. I guess the extension will be officially updated to 45 only when debian testing will get there... :cry:

You could try to manually install the build I did that contains this pull request. Run these terminal commands followed by a re-login:

wget https://github.com/khimaros/smart-auto-move/files/13418637/smart-auto-move%40khimaros.com.shell-extension.zip

gnome-extensions install --force smart-auto-move@khimaros.com.shell-extension.zip
khimaros commented 2 months ago

i'm happy to say that this seems to be working well for gnome-shell 45, 46, and the unreleased nightlies. the code looks fine to me and i will be merging this momentarily and pushing a release to EGO.