Refactor shortener module

khiro / urlshortener

url shortener for node.js

Other

4 stars 1 forks source link

Closed G07cha closed 8 years ago

G07cha commented 8 years ago

Using request library(moved to separate function)
All requests now returning only longUrl and shortUrl which make more easier to using this module
Update sample file
Update tests

Pros:

Cons:

khiro commented 8 years ago

Thanks, this PR is good in node "0.12.7". I have some comments. Please check a engine version in package.json and space indents in shortener.js.

Additionally, shortener_test.js has space and tab indents from the previous version. I will try to fix it after I merge this PR.

G07cha commented 8 years ago

As I set in config, it works in node "0.8.0".