search

khloke / play-to-xbmc-chrome

A Google Chrome Extension for sending online content to be played on XBMC. Supported websites include YouTube, Vimeo, CollegeHumor, DailyMotion, eBaumsWorld and SoundCloud.
MIT License
186 stars 112 forks source link

Add support for sending Magnet links to XBMCtorrent #11

Closed steeve closed 11 years ago

steeve commented 11 years ago

This PR allows to send magnet links to XBMCtorrent, as per issue #10.

khloke commented 11 years ago

I'll have a look at it soon. Thanks for the work.

khloke commented 11 years ago

I might make some changes and this will go into the next release :)

steeve commented 11 years ago

Awesome! Thank you :)

steeve commented 11 years ago

Hey!

I'll be likely releasing XBMCtorrent 0.4.0 this weekend. When do you think the next release will go out? Because and I'd love to showcase your addon with it :)

Thanks!

khloke commented 11 years ago

I usually wait for a few more new features for a release but I'm sure I could do a minor update before the weekend :)

On Thu, Oct 24, 2013 at 8:47 AM, Steeve Morin notifications@github.comwrote:

Hey!

I'll be likely releasing XBMCtorrent 0.4.0 this weekend. When do you think the next release will go out? Because and I'd love to showcase your addon with it :)

Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/khloke/play-to-xbmc-chrome/pull/11#issuecomment-26952905 .

Khee Hong Loke

steeve commented 11 years ago

AWE-SOME

khloke commented 11 years ago

Just to let you know that a new release is out with XBMCtorrent support.

On Thu, Oct 24, 2013 at 6:27 PM, Steeve Morin notifications@github.comwrote:

AWE-SOME

— Reply to this email directly or view it on GitHubhttps://github.com/khloke/play-to-xbmc-chrome/pull/11#issuecomment-26974524 .

Khee Hong Loke

steeve commented 11 years ago

Awesome thank you.

I'll make sure to announce with the new release :D

steeve commented 11 years ago

Oh by the way! 0.4.0 is out! http://j.mp/xbmctorrent

steeve commented 11 years ago

And I'll submit a PR for .torrent files too (more complicated, as we need to read the file and convert it to a magnet link in JS).

asfaltboy commented 10 years ago

@steeve :+1: I'd also love to see .torrent files support. I've just come accross parse-torrent npm package. It takes a torrent file (or stream) and returns a json object.

This object basically has all the torrent data (hash, files, trackers, pieces) to use it. Now, i'm not really sure how to pass this data to torrent2http binary. Can torrent2http also take "raw" data (perhaps read a local or in mem file?).

If torrent2http does indeed accept .torrent files, why don't we just pass the link to the file directly instead of magnet link? Or alternatively, we could create such a file in XBMCTorrent and pass it's path to the binary.

EDIT: After a bit of research into torrents and magnet links, it seems a magnet URI could be constructed with the data above, and it should work even with private trackers if the tracker uri is provided... So it should be fairly easy to construct the magnet link.

EDIT2: I'll move this to a separate issue as soon as I get a change.