Improvements discussion

[khmyznikov]

Feel free to suggest and discuss

[khmyznikov]

For now notification permission request shows up immediately after app starts. This needs to be changed for ability to call from JS code.

[khmyznikov]

I have made a push permission request from JS code.

[khmyznikov]

Fixed errors in requesting Location or Media APIs.

[dmytro-podolianskyi-ew]

Could you tell please, what about apple social login? I get an error [core] No URL for Apple ID Authorization Maybe do I need to add some configs or smth like that?

[khmyznikov]

Could you tell please, what about apple social login? I get an error [core] No URL for Apple ID Authorization Maybe do I need to add some configs or smth like that?

Do you use this library? I don't try it actually, not sure I can help.

[aidar87]

Could you tell please, what about apple social login? I get an error [core] No URL for Apple ID Authorization Maybe do I need to add some configs or smth like that?

I added Appleid domain to WKAppBoundDomains in Info file and using this guide https://developer.apple.com/documentation/sign_in_with_apple/sign_in_with_apple_js/configuring_your_webpage_for_sign_in_with_apple

[dmytro-podolianskyi-ew]

Thanks, it's working!

[dmytro-podolianskyi-ew]

Guys, maybe you help me again) What about google social login? When I try to login via google I stuck on the screen with loader and text "One moment please". I've added accounts.google.com to WKAppBoundDomains as the same as apple, but it's not working. Could you help please?

[khmyznikov]

Guys, maybe you help me again) What about google social login? When I try to login via google I stuck on the screen with loader and text "One moment please". I've added accounts.google.com to WKAppBoundDomains as the same as apple, but it's not working. Could you help please?

Try to debug via XCode and Safari dev tools. Maybe there are more domains than just accounts.google.

[aidar87]

@khmyznikov maybe it is time to add corrections to the readme for iOS 16.4 to prevent double Push from Web Push API and native Push API (for iOS devices < 16.4)

[khmyznikov]

@khmyznikov maybe it is time to add corrections to the readme for iOS 16.4 to prevent double Push from Web Push API and native Push API (for iOS devices < 16.4)

You have Web Push in this wrapper?

[aidar87]

You have Web Push in this wrapper?

Yes. But currently cannot test it on iOS 16.4 beta. Seems, there will no double Push in native wrapper, web push works only if PWA added home screen

[StillOnMyWay]

You have Web Push in this wrapper?

Yes. But currently cannot test it on iOS 16.4 beta. Seems, there will no double Push in native wrapper, web push works only if PWA added home screen

So to be clear, the Web Push doesn't interfere with the native push implementation in this wrapper?

[khmyznikov]

So to be clear, the Web Push doesn't interfere with the native push implementation in this wrapper? Yes, doesn't. Web Push doesn't work in WKWebView

[fenbru]

Hi @khmyznikov, do you have any demo repo where all functionalities are used?

Thx in advance.

[khmyznikov]

@fenbru what exactly functions? For Push there is code examples in Readme

[fenbru]

Sorry, my question wasn't specific.

Can you list all the places inside the project we should change for our website, not yours? @khmyznikov

[khmyznikov]

@fenbru Settings.swift, Info.plist. Change the urls/domains

[jcmaciel]

Hey guys, thanks for this repo, it's very useful. Let me know if I can help you ;)

[khmyznikov]

Hey guys, thanks for this repo, it's very useful. Let me know if I can help you ;)

Any experience in Swift? 😅