search

khoahre123 / pe

0 stars 0 forks source link

Edit client name into other existing client name #2

Open khoahre123 opened 2 years ago

khoahre123 commented 2 years ago

Step to reproduce:

Type in the command box the following: 1) add n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 s/6000 i/Interested in investing d/2022-01-20 f/true t/friends t/owesMoney

2) add n/John p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 s/6000 i/Interested in investing d/2022-01-20 f/true t/friends t/owesMoney

3) edit John Doe n/John

Expected: Some notice would be thrown saying that "John" already exists

Actual: Nothing was thrown, got exceptions in cmd

image.png

image.png

nus-se-script commented 2 years ago

Team's Response

Hi! Thank you for bringing up this issue. This bug occurs when there is a single word name (e.g. just John), causing a partial name clash. This is unlikely to occur in normal situations as clients usually have full names longer than 1 word. Hence, this is a rare situation and causes a minor inconvenience only. However, if you change to edit John n/John Doe the name clash error message appears and works as intended.

This is a similar issue to #2227 as this is a problem with a single method that finds the correct client using the name.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Cancelling a meeting not working despite providing correct input

1) Steps to reproduce, clear book and add 2 person with names 'test' and 'test 1'

2) assign meeting to both of them

image.png

3) Use command meet test 1 c/

4) Meeting is not cancelled.

[original: nus-cs2103-AY2122S2/pe-interim#2215] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi! Thank you for bringing up this issue. This bug occurs when there is a single word name (e.g. just John), causing a partial name clash. This is unlikely to occur in normal situations as clients usually have full names longer than 1 word. Hence, this is a rare situation and causes a minor inconvenience only.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Although clients usually have more than a single-word name, in many cases, they will only provide a single name, such as their first name or nickname, for confidentiality and convenience. Therefore, it is not a rare situation to catch this error.

Also, as no error message is shown, users can be confused and not know whether the operations are successful or not. In the case of an expert user, they would just assume that the operation is successful and move on. This will cause considerable inconvenience to their later actions.