search

khoahre123 / pe

0 stars 0 forks source link

Can not store correct name if client name contain "\" #3

Open khoahre123 opened 2 years ago

khoahre123 commented 2 years ago

Step to reproduce: Enter "add n/John s/o Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 s/6000 i/Interested in investing d/2022-01-20 f/true t/friends t/owesMoney" in the command box

Expected: Client with name "John s/o Doe" will be added

Actual: Only client with name John is added.

image.png

nus-se-bot commented 2 years ago

Team's Response

Hi! Thank you for bringing up this issue. This is the same as issue #2163.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Disallowing s/o in person name due to s/ being used as prefix

Steps to reproduce:

1) Add a person test s/o harun is a valid legal name

2) Its rejected as its is treated as a salary prefix

image.png

[original: nus-cs2103-AY2122S2/pe-interim#2159] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi! Thank you for bringing up this issue. Special characters in the name are not allowed in our application. As indicated in the image below, the application gives an error message stating that special characters are not allowed in names. As users can still type so instead of s/o and this only causes a minor inconvenience to the user.

Screenshot 2022-04-18 215700.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This is not a duplicate issue, because the below issues can give an error message, while my adding operation is successful, and no error was shown

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This is a serious issue as the operation was successful, while there should be at least an error message stating that only alphanumeric character is allowed

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: This was considered a Functionality Bug in the guideline

image.png

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: As the adding operation is successful, instead of throwing an exception message, but can only add a partial name. This would cause a lot of trouble when users want to find back this particular client, as they will assume the client's full name has been stored. Although the user can find the client again based on other information, it would take many steps and give significant annoyance to the user.