khoanq / jopenid

Automatically exported from code.google.com/p/jopenid
0 stars 0 forks source link

Missing maven dependency #2

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Please add a maven dependency like the one for code.google.com/p/google-gson/

Thx

Original issue reported on code.google.com by antoine....@gmail.com on 7 Jul 2009 at 7:50

GoogleCodeExporter commented 8 years ago
i am not familiar with maven but i will try

Original comment by askxuefeng@gmail.com on 27 Aug 2009 at 10:02

GoogleCodeExporter commented 8 years ago
Hi, 

Add a mavenrepo folder at the root of your svn directory just like
http://google-gson.googlecode.com/svn/mavenrepo/

in fact :
http://jopenid.googlecode.com/svn/mavenrepo/com/javaeedev/openid/
and put the needed files for maven...
that's not easy if you don't know maven

in fact i created my own modified version of jopenid (called openid4j for my
personnal use) under maven and referenced in my personnal maven directory. I 
attach
it if you want to check.

I also remove your base64.java file because i added the dependency on
org.apache.commons.codecs as we don't need to reinvent the wheel...
Just import it into Eclipse (with a maven plugin installed)

Thankyou for your work it's very lightweight and works just fine.

Original comment by antoine....@gmail.com on 27 Aug 2009 at 10:54

Attachments:

GoogleCodeExporter commented 8 years ago
Not having support for a maven repository doesn't mean that we have a defect or 
bug
on our code.

We are also definitely not reinventing any wheel. We didn't create Base64.java, 
it
was authored by Robert Harder as you can verify on it's source code. Including 
the
Base64.java is a matter of design decission. We did it that way because want to 
as
much as possible limit JOpenID's dependencies to only one library (which is the
Servlet API).

In the first place, you posted an invalid issue. Your label say's "Type-Defect" 
but
there was no bug or defect mentioned on your report.

Please try to post issues correctly next time.

Original comment by erwin.qu...@gmail.com on 11 Dec 2009 at 3:11