search

khoarus / rapidjson

Automatically exported from code.google.com/p/rapidjson
MIT License
0 stars 0 forks source link

Warning on MacOS X #62

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Hi,

I saw you fixed most of warnings with v0.11, great job (and fixed the assert 
with uint64 too).

I still have one warning when compiling on g++ on MacOS X 10.8.3 with rapidjson 
v0.11 :
rapidjson-0.11/rapidjson/include/rapidjson/reader.h:422: warning: comparison is 
always true due to limited range of data type

BTW, thanks for this great library :)

Original issue reported on code.google.com by mugimas...@gmail.com on 5 Apr 2013 at 8:59

GoogleCodeExporter commented 8 years ago 
I have this problem as well:

reader.h:422:31: warning: comparison of constant 256 with expression
      of type 'Ch' (aka 'char') is always true [-Wtautological-constant-out-of-range-compare]
                                if ((sizeof(Ch) == 1 || e < 256) && escape[(unsigned char)e])

Original comment by byvo...@gmail.com on 8 Dec 2013 at 12:29

GoogleCodeExporter commented 8 years ago 
I am getting this same behavior. Is there something that could be missing from 
the install instructions?

Original comment by Ron8...@gmail.com on 19 Jan 2014 at 4:56

GoogleCodeExporter commented 8 years ago 
I met it too.

I think it is harmless. Author doesn't want to use template specialization 
here:)

Original comment by zhangyaf...@gmail.com on 31 Mar 2014 at 6:34

GoogleCodeExporter commented 8 years ago

Original comment by milo...@gmail.com on 20 Jun 2014 at 11:58

GoogleCodeExporter commented 8 years ago 
We should have fixed quite a few warnings.
Currently it is tested with gcc/clang, as shown in 
https://travis-ci.org/miloyip/rapidjson
We will continue to fix other warnings.

Original comment by milo...@gmail.com on 30 Jun 2014 at 10:54

GoogleCodeExporter commented 8 years ago 
So is the svn repo obsolete now in favor of: 
https://github.com/miloyip/rapidjson ?

If so, perhaps update the "source" page here. Thanks!!

Original comment by k...@puppet.com on 30 Jun 2014 at 4:12

GoogleCodeExporter commented 8 years ago 
Yes. There is a big billboard in the front page :)

https://code.google.com/p/rapidjson/

Original comment by milo...@gmail.com on 30 Jun 2014 at 4:41

GoogleCodeExporter commented 8 years ago 
Haha, that's funny. Yeah I never went to that page. 

FYI I followed the link for this issue, then clicked on the "Source" tab, which 
still references the svn repo.

Thanks for all your great work!!

Original comment by k...@puppet.com on 30 Jun 2014 at 4:44