Hello! Thank you for submitting the second homework for CoderSchool React Class 🎉! The main focus of this assignment was to introduce you to working with React Native, rendering items in a FlatList, and dealing with navigation.
Great ✨
Really clean code! This is very good, didn't have to change many things in here.
Good job catching the errors when fetching movies in componentWillMount
Not so great yet 🚩
Do not leave console.log in the code :)
props is the named of properties given to your component. I suggest not creating another variable called props. For example:
Consider using eslint to spot unused imports and have consistent code quality across your code. We haven't had a dedicated time to do this, so it's mostly our fault. You can install it really easily by typing
yarn add -D eslint
eslint --init
I recommend chosing the guidelines from a popular company like Airbnb or Google. Then you can override some specific rules you don't like. Take a look at the .eslintrc.js file in my Suggestions for example of how to do that.
*
Good assignment overall 👏👏 You understand how to use the navigation, and pass informations to new screens, which was the goal ✅
If there's anything unclear with the feedback given here, please let us know!
Hello! Thank you for submitting the second homework for CoderSchool React Class🎉 ! The main focus of this assignment was to introduce you to working with React Native, rendering items in a FlatList, and dealing with navigation.
Great✨
componentWillMount
Not so great yet🚩
console.log
in the code :)props
is the named of properties given to your component. I suggest not creating another variable calledprops
. For example:Or
eslint
to spot unused imports and have consistent code quality across your code. We haven't had a dedicated time to do this, so it's mostly our fault. You can install it really easily by typingI recommend chosing the guidelines from a popular company like Airbnb or Google. Then you can override some specific rules you don't like. Take a look at the
.eslintrc.js
file in my Suggestions for example of how to do that.Good assignment overall 👏👏 You understand how to use the navigation, and pass informations to new screens, which was the goal ✅
If there's anything unclear with the feedback given here, please let us know!