search

khoatruong19 / df-frontend-2023

https://df-frontend-ass1.vercel.app
0 stars 0 forks source link

Submission for assignment 2 #2

Open khoatruong19 opened 12 months ago

khoatruong19 commented 12 months ago

https://df-frontend-ass2.vercel.app

chinhld12 commented 11 months ago

Solid work @khoatruong19 ,

Requirements

Final result: ✅ passed

Feedback

  1. Should use error handler for JSON parse method https://github.com/khoatruong19/df-frontend-2023/blob/b46d9e503b63d8a5aeb5343b88d4794602736f99/assignment-2/src/hooks/useBooks.js#L24-L25

  2. If possible can consider avoiding using inline functions for ref callbacks, cause React will allocate memory to recreate the new functions during every render. Can research with: avoid inline function in React

https://github.com/khoatruong19/df-frontend-2023/blob/b46d9e503b63d8a5aeb5343b88d4794602736f99/assignment-2/src/components/BooksActions.js#L16-L17 ...

  1. Your codebase is effectively maintaining well-organized code 👍 .
khoatruong19 commented 11 months ago

@chinhld12 Thank you for taking the time to give me some quality feedback!