Open khoatruong19 opened 1 year ago
Solid works,
Result: ✅ passed
Check your render on not found page (may related to sync URL state) and edit book modal focusing which made cannot author field correctly
The 404 Page does not appear appropriately when using the dark theme.
Logic for deleting the book just filter the book list is enough https://github.com/khoatruong19/df-frontend-2023/blob/35f7751d6de3d7c0a997640feeaec3445072aa39/assignment-4/src/hooks/useBooks.ts#L108-L112
+ const nextBooks = [...books].filter((item) => item.id !== id)
+ setBooks(nextBooks)
+ saveBooksToLocalStorage(nextBooks)
The logic of this places seem wrong? If the same data is expected to be returned before reaching the line to trigger an alert, you might want to consider using lodash
's isEqual
function to improve the comparison of objects
https://github.com/khoatruong19/df-frontend-2023/blob/35f7751d6de3d7c0a997640feeaec3445072aa39/assignment-4/src/hooks/useBooks.ts#L90-L97
types
should be under types
folders in your application folders tree, not utils
assignment-4/src/utils/types.ts
Some places still not completely migrated to Tailwind CSS
assignment-4/src/components/CustomThemeSwitch/styles.css
Consider using the HTML a
tag component for navigation, as it enhances the application's semantics and accessibility. You can utilize the Link
component from Next.js to address this situation.
https://github.com/khoatruong19/df-frontend-2023/blob/35f7751d6de3d7c0a997640feeaec3445072aa39/assignment-4/src/components/BookRow.tsx#L50-L56
df-frontend-ass4.vercel.app