search

khoih-prog / AsyncHTTPRequest_Generic

Simple Async HTTP Request library, supporting GET, POST, PUT, PATCH, DELETE and HEAD, on top of AsyncTCP libraries, such as AsyncTCP, ESPAsyncTCP, AsyncTCP_STM32, etc.. for ESP32 (including ESP32_S2, ESP32_S3 and ESP32_C3), WT32_ETH01 (ESP32 + LAN8720), ESP8266 (WiFi or W5x00) and currently STM32 with built-in LAN8742A Ethernet.
GNU General Public License v3.0
95 stars 29 forks source link

Remove unavailable items from `depends` field of library.properties #35

Closed per1234 closed 2 years ago

per1234 commented 2 years ago

The depends field of the library.properties metadata file specifies the dependencies that should be installed along with the library by the Arduino Library Manager.

This field must contain only the names of libraries that are available for installation via Library Manager.

The presence of any items which are not in Library Manager causes installation of the library to fail:

Originally reported at https://forum.arduino.cc/t/arduino-sdk-error-trying-to-download-library/967231

Related

khoih-prog commented 2 years ago

Hi @per1234

Thanks for the PR. We've been waiting and expecting those libraries to be added to Arduino Library Manager quite a long time.

Can someone help by forking them, then adding to Library Manager. Or Arduino Library Manager can be modified to add any library, by specifying git location, similar to library.json

https://github.com/khoih-prog/AsyncHTTPRequest_Generic/blob/e981dea8222a1d836a7df46969878a605ad152ec/library.json#L75-L78

Anyway, I'm merging the PR now to avoid issues.

per1234 commented 2 years ago

We've been waiting and expecting those libraries to be added to Arduino Library Manager quite a long time.

Yeah, it is really unfortunate that they aren't available via Library Manager since they are dependencies of many libraries.

Can someone help by forking them, then adding to Library Manager.

I think that is the best solution. The requests go back years without any response except for a bot closing them unjustly.

Arduino Library Manager can be modified to add any library, by specifying git location, similar to library.json

That is essentially how it works already. Anyone is welcome to submit any repository from any of the major Git hosting services. There is no requirement for it to be the library maintainer that makes the submission.

However, the library must be compliant with the requirements. From a quick glance, these libraries are compliant, except for one very important thing: a Git tag. Unfortunately, these repositories don't contain any tags. It would only take a matter of seconds to add them, but only someone with write permissions in the repository could do it.

khoih-prog commented 2 years ago

Hi @per1234

The new AsyncHTTPRequest_Generic releases v1.8.2 has just been published thanks to your PR. Your contribution is noted in Contributions and Thanks

Best Regards,

Releases v1.8.2

  1. Fix library.properties to remove unavailable items from depends. Check Remove unavailable items from depends field of library.properties #35
  2. Remove lorol's LittleFS_esp32 library dependency as LittleFS has been included in new ESP32 cores v1.0.6+
  3. Fix compile error for AsyncHTTPRequest_ESP_WiFiManager example
  4. Update Packages' Patches
khoih-prog commented 2 years ago

Hi @per1234

Anyone is welcome to submit any repository from any of the major Git hosting services. There is no requirement for it to be the library maintainer that makes the submission.

IMO, you're the best person to have them added into Arduino Library Manager and provide good services to the community.