khoih-prog / AsyncWebServer_RP2040W

Asynchronous WebServer Library for RASPBERRY_PI_PICO_W using CYW43439 WiFi with arduino-pico core. This library, which is relied on AsyncTCP_RP2040W, is part of a series of advanced Async libraries for RP2040W, such as AsyncTCP_RP2040W, AsyncUDP_RP2040W, AsyncWebServer_RP2040W, AsyncHTTPRequest_RP2040W, AsyncHTTPSRequest_RP2040W, etc. Now can display programmed WiFi country-code and support using CString to save heap to send very large data
GNU Lesser General Public License v3.0
25 stars 7 forks source link

LED state appears to be reversed. #2

Closed revell1 closed 2 years ago

revell1 commented 2 years ago

Describe the bug

In various examples, the use of the LED appears to be inverted. i.e. define LED_OFF HIGH define LED_ON LOW

It looks from the code as if the LED should be OFF while IDLE and turn on while processing a request. Where in fact the observed state of the LED looks like it is on ALL the time, the blink to OFF is so short that it is masked by the brightness of the LED.

Steps to Reproduce

Build and run any of the examples where LED is used, and observe LED state.

Expected behavior

As described above, would expect LED to be reversed.

Actual behavior

As described above, the LED appears to be ON all the time.

Debug and AT-command log (if applicable)

Used firefox to access target web address to cause request activity.

Screenshots

N/A

Information

khoih-prog commented 2 years ago

HI @revell1

Thanks for spotting the bug. It'll be fixed in next release.

Regards,

khoih-prog commented 2 years ago

Hi @revell1

The new AsyncWebServer_RP2040W releases v1.0.2 has just been published. Your contribution is noted in Contributions and Thanks

Best Regards,


Release v1.0.2

  1. Fix LED bug in examples