search

khoih-prog / AsyncWebServer_STM32

AsyncWebServer for STM32 using builtin LAN8742A Ethernet. This AsyncWebServer Library for STM32 is currently working on STM32 boards, such as Nucleo-144 F767ZI, etc., using builtin LAN8742A Ethernet. Now support using CString to save heap to send very large data
GNU Lesser General Public License v3.0
20 stars 5 forks source link

v1.2.5: Compilation broken due to error in STM32AsyncTCP dependency #4

Closed dl1com closed 3 years ago

dl1com commented 3 years ago

Description

As already described in #2 by @jcw, there is an issue with the external dependency of the STM32AsyncTCP Library. In the current version (1.2.5) of AsyncWebServer_STM32, compilation fails with just the same error as described in #2, as the root of the cause is still not fixed upstream, the library.json of the library still states the wrong platform ("platforms": "espressif8266", https://github.com/philbowles/STM32AsyncTCP/blob/master/library.json#L18).

Workaround

To get my setup working, I just refer to your fork of the library in my platform.ini, as your fork already contains the relevant fix:

lib_deps =
    STM32AsyncTCP=https://github.com/khoih-prog/STM32AsyncTCP
    khoih.prog/AsyncWebServer_STM32@^1.2.5

Short-Term Solution

I'd propose that you alter your library.json to point to your fork of the lib (https://github.com/khoih-prog/AsyncWebServer_STM32/blob/master/library.json#L42) until it is fixed upstream.

Please let me know if I shall supply this as a PR, I am happy to do so.

Long-Term solution

PR the relevant fixes in the upstream repo of philbowles.

khoih-prog commented 3 years ago

Hi @chris007de

Thanks for your contribution. As the issue is spanning across several libraries, I have to take over to modify and release the new version.

Your and Jean-Claude contributions have been noted in Contributions and Thanks

Please check to see if there still any other issue.

Releases v1.2.6

  1. Fix dependency on unpublished STM32AsyncTCP Library. Check Compilation broken due to error in STM32AsyncTCP dependency and how to run one of the examples?.
dl1com commented 3 years ago

Thanks a lot, it's fixed with v1.2.6.