khoih-prog / Blynk_Async_WM

Simple WiFiManager for Blynk and ESP8266/ESP32 (including ESP32-S2, ESP32-C3) with or without SSL, configuration data saved in either LittleFS, SPIFFS or EEPROM. This library, using AsyncWebServer instead of (ESP8266)WebServer, for configuring/auto(re)connecting ESP8266/ESP32 modules to best or available MultiWiFi APs and MultiBlynk servers at runtime. Enable adding dynamic custom parameters from sketch and input using the same Config Portal. Config Portal will be auto-adjusted to match the number of dynamic parameters. Optional default Credentials to be autoloaded into Config Portal to use or change instead of manually input. Static STA IP and DHCP Hostname as well as Config Portal AP channel, IP, SSID, Password can be configured. Multi or Double DetectDetector feature permits entering Config Portal as requested.
MIT License
20 stars 8 forks source link

custom Blynk port not working for BlynkSimpleEsp32_Async_WM.h #4

Closed jjskaife closed 3 years ago

jjskaife commented 3 years ago

Describe the bug

Custom blynkport from Credentials.h is not being used, instead it looks like the hard coded value is. This work fine for ESP8266 but not ESP32. The code looks different.

Steps to Reproduce

Blynk port changed to 8082 in Credentials.h

Expected behavior

Blynk should connect to on 8082.

Actual behavior

Blynk tries to connect to port 8080.

` //existing line 2068 in BlynkSimpleEsp32_Async_WM.h BlynkESP32_WM_config.Blynk_Creds[i].blynk_server, BLYNK_SERVER_HARDWARE_PORT);

//works if I change to this BlynkESP32_WM_config.Blynk_Creds[i].blynk_server, BlynkESP32_WM_config.blynk_port);`

The above change seems consistent with the ESP8266 file which does work properly.

khoih-prog commented 3 years ago

Thanks to point out the bug. I'll update in next release.

khoih-prog commented 3 years ago

Just published the new Blynk_Async_WM releases v1.4.1 to fix the issue. Your contribution is noted in Contributions and Thanks.

Thanks and Regards,

khoih-prog commented 3 years ago

Your contribution is also noted in Contributions and Thanks of this library's twin Blynk_WM