search

khoih-prog / ESPAsync_WiFiManager

This is an ESP32 (including ESP32-S2 and ESP32-C3) / ESP8266 WiFi Connection Manager, using ESPAsyncWebServer, with fallback web configuration portal. Use this library for configuring ESP32, ESP8266 modules' WiFi, etc. Credentials at runtime. You can also specify static DNS servers, personalized HostName, fixed or random AP WiFi channel. With examples supporting ArduinoJson 6.0.0+ as well as 5.13.5- . Using AsyncDNSServer instead of DNSServer now.
MIT License
290 stars 73 forks source link

fix: ending portal loop without processing its flags #119

Closed slaesh closed 1 year ago

slaesh commented 1 year ago

since the yield was AFTER processing the flags (connect/stop).. AND we were modifying the loop-criteria, the loop could end BEFORE we had processed our flags!

SO, yield before and there is no need to modify the timeout at all :)

khoih-prog commented 1 year ago

HI @slaesh

Please clarify and post some MRE to explain what's wrong and the bug this PR fixes, so that anybody can duplicate the issue and know the benefit of the bug fix.

Not enough with just some words.

Thanks,

khoih-prog commented 1 year ago

OK, I'm merging now. Thanks

khoih-prog commented 1 year ago

Hi @slaesh

The new ESPAsync_WiFiManager v1.15.1 has just been released. Your contribution is noted in Contributions and Thanks

Best Regards,

Releases v1.15.1

  1. Using random channel for softAP without password. Check fix: using random CH for non-password use too #118
  2. Fix bug. Check fix: ending portal loop without processing its flags #119
  3. Add astyle using allman style. Restyle the library