search

khoih-prog / ESPAsync_WiFiManager

This is an ESP32 (including ESP32-S2 and ESP32-C3) / ESP8266 WiFi Connection Manager, using ESPAsyncWebServer, with fallback web configuration portal. Use this library for configuring ESP32, ESP8266 modules' WiFi, etc. Credentials at runtime. You can also specify static DNS servers, personalized HostName, fixed or random AP WiFi channel. With examples supporting ArduinoJson 6.0.0+ as well as 5.13.5- . Using AsyncDNSServer instead of DNSServer now.
MIT License
294 stars 74 forks source link

Connect to WiFi AP using WPS #86

Closed mawi42 closed 2 years ago

mawi42 commented 2 years ago

Sure you can start the config portal and configure the WiFi connection. However since there is WPS supported by ESP libs I guess it would be nice before starting config portal to check if WPS connection is possible (e.g. optional). Is there any plan to add this feature?

khoih-prog commented 2 years ago

Hi @mawi42

Thanks for your interest in the library and the enhancement request.

I have no plan now to add the WPS feature to the library, but if there are many more requests, I certainly will rethink.

Regards,

mawi42 commented 2 years ago

Hi,

thank you for the fast feedback.

In case I implement this feature are you interested to receive it as pull request?

Best regards

Matthias

Am 22.02.2022 22:51, schrieb Khoi Hoang:

Hi @mawi42 [1]

Thanks for your interest in the library and the enhancement request.

I have no plan now to add the WPS feature to the library, but if there are many more requests, I certainly will rethink.

Regards,

-- Reply to this email directly, view it on GitHub [2], or unsubscribe [3]. Triage notifications on the go with GitHub Mobile for iOS [4] or Android [5]. You are receiving this because you were mentioned.Message ID: @.***>

Links:

[1] https://github.com/mawi42 [2] https://github.com/khoih-prog/ESPAsync_WiFiManager/issues/86#issuecomment-1048246381 [3] https://github.com/notifications/unsubscribe-auth/AGJSKEDRLWSN4SAPLZGEZSDU4QAMJANCNFSM5PCSAEGQ [4] https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 [5] https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

khoih-prog commented 2 years ago

Certainly your PR will be appreciated and merged when proven OK.

mawi42 commented 2 years ago

Hi again,

so I started to look in more detail into your lib and have to say it is not so easy to find a good logic and place to add the WPS easily. So for now I will just use it as it is and will not add - I just want to let you know.

Thank you anyway for the nice lib

Best regards

Matthias

Am 22.02.2022 22:51, schrieb Khoi Hoang:

Hi @mawi42 [1]

Thanks for your interest in the library and the enhancement request.

I have no plan now to add the WPS feature to the library, but if there are many more requests, I certainly will rethink.

Regards,

-- Reply to this email directly, view it on GitHub [2], or unsubscribe [3]. Triage notifications on the go with GitHub Mobile for iOS [4] or Android [5]. You are receiving this because you were mentioned.Message ID: @.***>

Links:

[1] https://github.com/mawi42 [2] https://github.com/khoih-prog/ESPAsync_WiFiManager/issues/86#issuecomment-1048246381 [3] https://github.com/notifications/unsubscribe-auth/AGJSKEDRLWSN4SAPLZGEZSDU4QAMJANCNFSM5PCSAEGQ [4] https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 [5] https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

khoih-prog commented 2 years ago

I'd appreciate it if you can post the sample WPS code or link so that if I have some time, I can try to include it in any of my WiFiManager libraries.

Thanks for your try and contribution so far,

Best Regards,