Closed khoih-prog closed 1 year ago
LGTM. You've written very good code.
Can you make some minor changes to match with the current styles
AWS_LOGDEBUGx
instead of Serial.printxx
README.md
correctly by adding a note how to use the new feature / functionBTW, to create a PR, after you've forked the library and have done all the mods, just press Pull Requests
(upper left corner, next to Code
, and proceed. Just so simple for you.
Replaced by the real PR #8
This PR is from @salasidis
As per the Readme.md file - I am getting 66k instead of 374k max heap space in my application. I should have no problem sending 2M files, or web pages larger than the main RAM
Since I create the web page once, and reuse, I make a second copy of the web page, so that when the send happens (which messes wit the actual string), I simply recopy C string C string for the next send - fast, easy, and almost no code changes required (none if you don't wish to use the features 0 fully backwards compatible I think)