Fixed warnings from cppcheck (platformio) and -Wall arduino-cli

khoih-prog / TimerInterrupt

This library enables you to use Interrupt from Hardware Timers on an Arduino, such as Nano, UNO, Mega, etc. It now supports 16 ISR-based timers, while consuming only 1 hardware Timer. Timers' interval is very long (ulong millisecs). The most important feature is they're ISR-based timers. Therefore, their executions are not blocked by bad-behaving functions or tasks. This important feature is absolutely necessary for mission-critical tasks.

MIT License

98 stars 11 forks source link

Fixed warnings from cppcheck (platformio) and -Wall arduino-cli #10

Closed Django0 closed 3 years ago

Django0 commented 3 years ago

Based on the issue #8 raised, this is now fixed. Only tested the compilation of examples/Argument_Simple/Argument_Simple.ino. Do let me know if you have any automated tests that can be run. Also, do let me know if I have overlooked anything with this commit.

khoih-prog commented 3 years ago

I'm sorry to let this PR waiting too long time as I've been busy with other things recently.I'm merging it now to master and will update many other related TimerInterrupt libraries (such as TimerInterrupt_Generic ), if applicable.

Thanks for the PR, and especially the explicit constructor conversion to prevent unwanted implicit cast.

I'm looking forward for receiving more of your contributions / PR,

Best Regards,