search

khoih-prog / WebSockets2_Generic

A WebSocket Server and Client library for Arduino, based on RFC6455, for writing modern Websockets applications. Now support ESP8266, ESP32 (including ESP32-S2 Saola, AI-Thinker ESP-12K, WT32_ETH01, etc.), nRF52, SAMD21, SAMD51, SAM DUE, STM32F/L/H/G/WB/MP1, Teensy, RP2040-based, etc. boards, with WiFiNINA, Teensy 4.1 NativeEthernet/QNEthernet, Ethernet W5x00 / ENC28J60 / LAN8742A / LAN8720, ESP8266 / ESP32-AT modules/shields, as well as SINRIC / Alexa / Google Home
GNU General Public License v3.0
81 stars 30 forks source link

Fix QNEthernet TCP interface #35

Closed ssilverman closed 2 years ago

ssilverman commented 2 years ago

It now compiles. Also remove unnecessary yield() calls.

khoih-prog commented 2 years ago

Thanks for your PR.

I didn't spend time to retest your library recently, which has been upgraded a lot, and am not aware of the compiler-error issue.

Thanks a lots for you PR, which is tested and running great now.

A new release will be published soon and your contribution will be noted.

Best Regards,

ssilverman commented 2 years ago

The reason those yield() calls can be deleted is because all those functions now internally call Ethernet::loop(). The compiler error was because EthernetServer only has a “port” constructor and must be recreated when listening on a new port. I might explore adding a begin(port) call…

khoih-prog commented 2 years ago

Hi Shawn,

Just published the new WebSockets2_Generic releases v1.9.1 with a note about your contribution in Contributions and Thanks.

Hoping to get more PRs from you.

Best Regards,

Release v1.9.1

  1. Fix compile error for Teensy 4.1 using new QNEthernet library version. Check Fix QNEthernet TCP interface #35
  2. Update Packages' Patches
  3. Verify working with new Arduino IDE v1.8.18
  4. Update library.json and platform.ini for newly published QNEthernet library