Submission week2 assignment

[khoinguyen91]

Here's my submission for CoderChat app. Since It's too ugly, I will try make it look better tomorrow. Please have a look and give me feedback if any

/cc @coderschoolreview /cc @harley.

[hoksilato]

Hi @khoinguyen91, nice work with your homework :+1:

The goals of this homework are:

• to know how to implement authentication from scratch in Rails with the help of the has_secure_password class method and the brypt gem (while understanding what they do under the hood)
• to design a more complex schema for a web app and be more familiar with ActiveRecord API such as custom foreign keys for belongs_to/has_many, using has_many :through and building more advanced queries by chaining where, order, and merge
• to build more complex forms in views that involve multiple models.

Quick review:

• Clean custom routes.
• Good logic with not allow users to add friend and send message to themselves.
• Great job with application helper methods require_login, signed_in? and skipped_login.
• Good work with check whether user signed in or not before list all messages.
• Good use with message partial.
• Good work with associations between models.

Suggestions

• Should validate email presence and its validity on your sign up form.
• Should validate new message form.
• Should not display Sign Up, Sign in with Facebook after user signed in.
• Should also check whether user signed in or not before create new message and add friend too.

Gemfile:

• I didn't see you include rails_12factor gem for Heroku.

Congrats again on the submission. Everyone has limited time; it's good to see you finished all required and some optional functionalities. Keep your good work :100: Let us know if you have any feedback.