search

khoj-ai / khoj

Your AI second brain. Self-hostable. Get answers from the web or your docs. Build custom agents, schedule automations, do deep research. Turn any online or local LLM into your personal, autonomous AI (e.g gpt, claude, gemini, llama, qwen, mistral).
https://khoj.dev
GNU Affero General Public License v3.0
14.18k stars 705 forks source link

Can't access search in Obsidian [FIX] #623

Closed edbock closed 9 months ago

edbock commented 9 months ago

Describe the bug

A clear and concise description of what the bug is. Please include what you were expecting to happen vs. what actually happened. Thank you for the Dataview fix. It's nice to have the chat window in Obsidian now. However, I no longer have access to the regular incremental search box.

Before: clicking the magnifying glass would bring up incremental search. Typing in the box would produce instant results. After: clicking the magnifying glass brings up the chat window. I can't find the search window option.

I tried creating a hotkey for search, and it does bring up a window but without the text entry portion. I can only select from my previous search results.

Platform

If self-hosted

debanjum commented 9 months ago
  1. I'd removed Khoj search and replaced it with Khoj chat in the side ribbon. Just kept one Khoj command on the side ribbon to avoid clutter and felt folks chat more than search. I can add it back if required
  2. For now though you should be able to find Khoj: Search in your Obsidian command palette. You can also bind Khoj: Search to a Hotkey in Obsidian for easier access

I tried creating a hotkey for search, and it does bring up a window but without the text entry portion. I can only select from my previous search results.

This sounds strange. Can you share more details, screenshots of what this modal looks like and the hotkey binding you did? There is a Khoj: Find Similar Notes command that allows you to find notes similar to the currently open note. The behavior you describe sounds somewhat similar to what you'd see when you run that command

edbock commented 9 months ago

Oops, my bad. I didn't look carefully enough at the hotkeys and indeed, that's what was happening. In fact, I'm very happy you pointed me back in that direction. The similar notes feature is fantastic, and is high on the list of features I would have requested.

If I hadn't been so focused on looking for and fixing issues I would have figured this out myself. That said, you might want to make these features a little more prominent in the docs.

I would say you are probably fine to leave search as the default. I agree having two buttons might clutter things up a bit too much. On the other hand, if it's not hard to do maybe you can add the option for users to select either/or, or both.

Thank you for your patience in helping me figure this out.

debanjum commented 9 months ago

Glad we resolved the confusion and you found the similar notes feature useful! It is mentioned in the docs but we should add more details/images explaining the available commands for sure!