search

khoj-ai / khoj

Your AI second brain. Self-hostable. Get answers from the web or your docs. Build custom agents, schedule automations, do deep research. Turn any online or local LLM into your personal, autonomous AI (e.g gpt, claude, gemini, llama, qwen, mistral).
https://khoj.dev
GNU Affero General Public License v3.0
14.13k stars 703 forks source link

Replaced reinitialize and save all button to a sync button in config.… #701

Closed AjaySDwivedi1 closed 6 months ago

AjaySDwivedi1 commented 7 months ago

…html

sabaimran commented 7 months ago

Thanks for raising a PR for this, @AjaySDwivedi1 ! In the future, be sure to wait for confirmation in the issue before raising a PR. It's often helpful just to get an acknowledgement and make sure we're on the same page before making code changes.

Have you tested the PR? Can you add a screenshot/video recording of the changes to your PR?

AjaySDwivedi1 commented 6 months ago

Thanks for raising a PR for this, @AjaySDwivedi1 ! In the future, be sure to wait for confirmation in the issue before raising a PR. It's often helpful just to get an acknowledgement and make sure we're on the same page before making code changes.

Have you tested the PR? Can you add a screenshot/video recording of the changes to your PR?

Sorry about that! I have been super busy recently, however I can make the changes you request. Do you want to me to submit a screenshot of the working code with the new commit that the has the proper changes?

AjaySDwivedi1 commented 6 months ago

@sabaimran I am not getting the right page format when I run the program. I am currently doing "start config.html" in the terminal. If you have a better way of running the program let me know!

sabaimran commented 6 months ago

Hey @AjaySDwivedi1 , do you have the khoj app running locally on your machine? You'll have to follow the setup instructions in the docs and get it running. Then you can navigate to http://localhost:42110/config to test your changes. Let me know if you run into issues? Would be best to send a message in the Discord if you need help and tag one of us.

AjaySDwivedi1 commented 6 months ago

@sabaimran quick question. In the sync.addEventListener, do you want to new icon to be the emoji? I'm having trouble printing the icon when that function is called.

sabaimran commented 6 months ago

It doesn't have to be in the event listener, but the recycle icon next to the "Reinitialize" text should be updated with the new one. Currently, it's this: ♻️.

AjaySDwivedi1 commented 6 months ago

image Proof for the new commit. If I need to change anything let me know!

sabaimran commented 6 months ago

Nice! Thanks for the update Ajay. Can you just make them side by side, like it was previously? It should be (icon) (text) on the same horizontal line.

AjaySDwivedi1 commented 6 months ago

Nice! Thanks for the update Ajay. Can you just make them side by side, like it was previously? It should be (icon) (text) on the same horizontal line.

I can try but I used the docker file to run the program and it's no longer working for some reason and the python commands give me a weird error that I've tried to fix, but nothing has been working. What were did my code fail in the checkpoint? I wasn't able to tell.

sabaimran commented 6 months ago

What error are you seeing in the docker setup?

AjaySDwivedi1 commented 6 months ago

What error are you seeing in the docker setup?

I wasn't getting any errors in the docker setup when it was working, but for some reason my desktop docker app is no longer working. Sometimes it works for a second but then it crashes. If your able to, can you explain where the pre-commit / Run Tests (pull_request) checkpoint is failing? Because I can try to fix it and do another commit to test it. I the the sync.svg file is where the error is but I am not 100% sure.

sabaimran commented 6 months ago

Hey @AjaySDwivedi1 , yup the error was that the linter expected a new line at the end of sync.svg. No worries, I went ahead and fixed it so that we can get this change merged in time for our release today. Thanks for contributing and accommodating the feedback!

sabaimran commented 6 months ago

Closes #700