search

khonsulabs / bonsaidb

A developer-friendly document database that grows with you, written in Rust
https://bonsaidb.io/
Apache License 2.0
1.01k stars 37 forks source link

add repr support for derive Key on enum #244

Closed ModProg closed 2 years ago

ecton commented 2 years ago

This looks great. One question I had is: should there be an error if you specify enum_repr on a struct? It obviously has no effect, but I think it would be nice to tell the user it's pointless to use on a struct.

ModProg commented 2 years ago

This looks great. One question I had is: should there be an error if you specify enum_repr on a struct? It obviously has no effect, but I think it would be nice to tell the user it's pointless to use on a struct.

not a bad idea, should be easy to add.

ecton commented 2 years ago

Thank you again! I'll amend the docs with the new details on this impl.