search

khonsulabs / bonsaidb

A developer-friendly document database that grows with you, written in Rust
https://bonsaidb.io/
Apache License 2.0
998 stars 37 forks source link

Lifetime for `#[derive(Key)]` #286

Closed ModProg closed 1 year ago

ModProg commented 1 year ago

fixes #283

Also fixes an issue where the lifetimes in #[derive(Key)] clashed with lifetime names on the struct (especially 'b)

ecton commented 1 year ago

Thank you for tackling this so quickly! it's a shame the workaround you had to do for proc-macro-error. CI is showing a few issues -- hopefully they aren't too bad!

ModProg commented 1 year ago

CI is showing a few issues -- hopefully they aren't too bad!

I'll have a look, must have missed them testing locally

ecton commented 1 year ago

Thank you for this! I still don't fully understand why we ran into the syn 2.0 issues on CI but not when we tested locally initially. But, I'm glad you sorted it out!

I've also extended an invite to the project which will hopefully cause your actions to trigger automatically in the future.

ModProg commented 1 year ago

Thank you for this! I still don't fully understand why we ran into the syn 2.0 issues on CI but not when we tested locally initially.

Because we didn't run cargo update locally.