khonsulabs / cushy

An experimental cross-platform graphical user interface (GUI) crate for Rust.
Apache License 2.0
492 stars 25 forks source link

Naming inconsistencies and suggestions #218

Open ecton opened 3 days ago

ecton commented 3 days ago

From @hydra on Discord:

looking at the names of methods that you can call, there's some inconsistent ordering between <orientation/direction> and <orientation/direction>

for example: .horizontal_scroll() .vertical_scroll() .align_top() .aligh_left() .collapse_vertically() .collapse_horizontally()

suggest being consistent here and use _<orientation/direction>

thus suggest renaming as follows: .horizontal_scroll() -> scroll_horizontally() .vertical_scroll() -> scroll_vertically()

I note that labels have lots of methods like these:

.x_large() .xx_large() // ... and ... .h1() .h2() // ...

wondering if it might be better to prefix the size ones with size_, e.g. size_xlarge() and prefix the css-like ones with header, e.g. header_h1.

The thinking behind this is so they're all grouped together when you're using the IDE auto-complete after typing . as they methods names are alphabetically sorted by the IDE.