search

khor-jingqian / pe

0 stars 0 forks source link

Broken links in DG #21

Open khor-jingqian opened 3 years ago

khor-jingqian commented 3 years ago

Commons, UI LOgic and model and storage c

image.png

nus-se-bot commented 3 years ago

Team's Response

This error happens for majority when we convert pdf from website.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hello, thank you for the response to my bug report.

I tried the other links in your DG, such as:

  1. Main and Mainapp

image.png

2.Ui.java, MainWindow, MainWindow.fxml

image.png

  1. Documentation guide, Testing guide, Logging guide, Configuration guide

image.png

All these hyperlinks seem to be working. Seems that you forgot to test these hyperlinks that I clipped in the original screenshot. Additionally, broken links in the DG are a valid cause for bug reports as written in PE grading scheme.

image.png

Furthermore, I think this gitter post from Prof Damith also states that links in your UG/DG that should be pointing to other sections should not be opening up your browser, but should jump to the indicated point in the PDF, which is the case for most of your hyperlinks actually.

https://gitter.im/nus-cs2103-AY2021S1/community?at=5fb39c5bd5a5a635f2c78103

Hope these examples help to convince your team as to why I am reopening this report.