search

khor-jingqian / pe

0 stars 0 forks source link

Misleading error message for deleting non-existent tags #5

Open khor-jingqian opened 3 years ago

khor-jingqian commented 3 years ago

I am not sure why it tells me that the tags have been edited then followed by the deletion of a nonexisten tag. it should simply throw an error telling me no such tag. image.png

Likewise for creating new tags

nus-se-bot commented 3 years ago

Team's Response

In my opinion, this should be "VeryLow" severity because it does not actually affect the usage of users trying to delete a non-existing tag or adding existing tags. It should also be considered as a "FeatureFlaw" and not a "FunctionalityBug" because it can be considered as an incomplete implementation of the tag command. What I could do is that I can cater this type of commands and have personalised error messages for it. In this case, I treated error messages as the Deletion of non-existing tags detected: [[nonexistenttag]] but did not consider the top sentence of Tags edited for Task....

Items for the Tester to Verify

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: image.png

The error message does not match the error. The first line is completely misleading to the user, saying that there has indeed been a tag edited.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: I believe that this is a serious bug that should have been handled more carefully. However, I would like to lower the severity to a low because it might not be very common for a user to delete tags for a task.

image.png

The first line clearly reads as a success message to the user. It is not very logical to start an error message with this line that reads Tags edited.... implying that there was a change done to the tags, when this is an error. Furthermore, the error message is not red or any other color to signify that this is an error message. A user can simply glean across this message and think that the tag was actually deleted. Upon closer reading of your UG, it did not warn the user what kind of error they should be expecting for wrong tags or for inputs with missing tags.