khoren93 / flutter_zxing

Flutter plugin for scanning and generating QR codes using the ZXing library, supporting Android, iOS, and desktop platforms
https://pub.dev/packages/flutter_zxing
MIT License
92 stars 52 forks source link

Severals fix #35

Closed bounty1342 closed 1 year ago

bounty1342 commented 1 year ago

Hi,

Made several improvement on the reader_widget.dart :

  1. Fix WidgetsBindingObserver not working on app after injecting reader_widget du to SystemChannels.lifecycle.setMessageHandler
  2. Avoid memory leak by removing removeListener
  3. Replace method _flashIcon by widget _FlashIcon
  4. Pass a widget argument for the loader to give more customisation
  5. Pass a duration argument to customise duration after successful scan
  6. Don't instantiate new camera if the old one not disposed

Hope you like it. Don't hesitate contact me if needed.

Regards,

khoren93 commented 1 year ago

@bounty1342 That’s awesome, Thanks a lot 🙂

bounty1342 commented 1 year ago

@khoren93, could you push a 0.8.2 ?

khoren93 commented 1 year ago

@bounty1342 Done