search

khoren93 / flutter_zxing

Flutter plugin for scanning and generating QR codes using the ZXing library, supporting Android, iOS, and desktop platforms
https://pub.dev/packages/flutter_zxing
MIT License
89 stars 50 forks source link

flutter_zxing: `melos` should be a dev dependency, not direct dependency #98

Closed phlip9 closed 1 year ago

phlip9 commented 1 year ago

It looks like melos was accidentally added as a direct dependency to flutter_zxing. This adds a ton of extra, unnecessary dependencies to any dependent apps/packages. Fortunately the fix is pretty easy: just make it a dev dependency.

The first commit is the side effects of running melos bootstrap with the latest flutter stable. It also includes some new, minor dart format and flutter analyze fixes from the latest stable.

The second commit actually moves melos to the dev dependencies section, which shrinks the example/ and zxscanner pubspec.lock's a bit.

khoren93 commented 1 year ago

Dear @phlip9

I wanted to express my sincere gratitude for fixing the dependency issue in the GitHub Pull Request for flutter_zxing. Your solution to convert melos into a dev dependency was brilliant and greatly improved the project.

Thank you for your attention to detail and quick action.

Best regards,

Khoren