search

khpylon / MachEWidget

Android Widget for Ford Mustang Mach-E
GNU General Public License v3.0
35 stars 10 forks source link

Bug - widget size #4

Closed mporet closed 2 years ago

mporet commented 2 years ago

Widget footprint takes up almost an entire home screen. This is on Galaxy S20+ Screenshot_20220206-224135_One UI Home

mporet commented 2 years ago

If it helps with debugging this issue I found that if I put it on a home screen that already has a large number of items, it will shrink its footprint by one row vertically

Screenshot_20220206-224658_One UI Home

khpylon commented 2 years ago

Thanks for the info. Google doesn't give very detailed explanation of handling widget resizing but I think I've found something which works now. I'll add it to the next release in a day or two.

khpylon commented 2 years ago

I pushed a new release a few minutes ago which should allow you to resize the widget (at least it lets me do it on my emulator and on my phone using the Pixel Launcher). Let me know what you see.

benk016 commented 2 years ago

Mine does this with todays update. The widgets fit into Rows of icons, SO it only snaps to the next size of icons. So there is blank space between the top and bottom of the app because the space it needs is smaller than 4 icon rows.

khpylon commented 2 years ago

The widget isn't exactly the height of a row of icons, so there is some unused space. It was a pain to manually place everything before (I actually did it twice) but I'll put add an attempt to make it fit more closely in my TODO list.

mporet commented 2 years ago

Looks great! Can confirm it is resizable now. Thank you! As mentioned above, it is not lining up with the grid but it is smaller Screenshot_20220208-132933_One UI Home

khpylon commented 2 years ago

The next release should have changes to the size of the widget. My observations is that each launcher interpret the size of the widget independently. I've resize to be close to what Pixel Launcher thinks is the "grid size", but Nova thinks it's totally different. I'm going to use Pixel Launcher as my baseline so we'll just have to see how it works out for other launchers (like Samsung's).

benk016 commented 2 years ago

This newest update did change the size on my Samsung S21. It now uses 3 rows instead of 4.

Screenshot_20220210-123246_One UI Home

khpylon commented 2 years ago

I'm planning to close this out unless anyone is still seeing something weird/wrong.

mporet commented 2 years ago

Been working for the last day for me!

On Fri, Feb 18, 2022, 10:50 AM khpylon @.***> wrote:

I'm planning to close this out unless anyone is still seeing something weird/wrong.

— Reply to this email directly, view it on GitHub https://github.com/khpylon/MachEWidget/issues/4#issuecomment-1044914247, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3PIC5VMAWPYZRQ7YLMK6TU32BHFANCNFSM5NWOWLHQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>