search

khromov / wp-wpml-geoip-browser-language-redirect

GeoIP Redirector for WPML (WordPress)
GNU General Public License v2.0
46 stars 17 forks source link

You dont take serious the bug.... #13

Closed mastercho closed 8 years ago

mastercho commented 8 years ago

Ok you closed my recent ticked, so i install fresh wordpress whit WPML and your plugin, opened from fresh installed firefox because i have some extensions on chrome, and still same problem.

Uncaught TypeError: Cannot read property 'log' of undefined browser-redirect-geoip.js:23

But nevermind i see there's a lot of reports not only in git you have it also in your official website comments that its not working and you are keep saying its working. But its not. Probably you are not have time to check it. Just mark plugin as non-working...

khromov commented 8 years ago

@mastercho The plugin works fine for me and many other people, but it's not an "activate it and forget it" solution, it might require additional configuration or adaption to your specific environment.

It's impossible to provide support if you can't even get the javascript console to work, but if you do, feel free to post any issues you are having.

mastercho commented 8 years ago

Tell me which version of wpml you use and what theme so i can try it

mastercho commented 8 years ago

Also which version of wordpress ?

ScottEAdams commented 8 years ago

I have WPML 3.3.6 with x theme, latest WP etc and it works great. Slight delay in the redirect but otherwise flawless.

mastercho commented 8 years ago

I have removed WPML 3.3.5 and install WPML 3.3.6 but was still same, so next what i done was to remove redirect plugin and reupload & install it again, after this magic happen its redirected me to country based IP so i refresh to page to see is working good? But after i reload the page for second time its not redirected me, i clean cache and cookies and wait 30 min and try it again and again redirected me once and after reload stop working, strange why is just 1 time is redirected with slight delay.

khromov commented 8 years ago

Sounds like you got it working @mastercho !

The reason for performing only a single redirect is to not force the user into a specific language. This mimics the default WPML implementation.

For more on the reasoning, see: https://github.com/khromov/wp-wpml-geoip-browser-language-redirect/pull/11#issuecomment-187177123

mastercho commented 8 years ago

So theres no way to force always country base ip?

khromov commented 8 years ago

@mastercho Forcing is a bad idea, but If you check that pull request, it contains changes to do that, but it's up to you to integrate them if you want it.

mastercho commented 8 years ago

So if i add var forceRedirect = true; on JS file will force them?

khromov commented 8 years ago

@mastercho No, but replacing the file browser-redirect-geoip.js with the proposed changeset should get you there.

https://github.com/khromov/wp-wpml-geoip-browser-language-redirect/blob/c172bae1532151e7719218cbc3e07e97b996ee63/js/browser-redirect-geoip.js

mastercho commented 8 years ago

Okay thank you my friend.