khromov / wp-wpml-geoip-browser-language-redirect

GeoIP Redirector for WPML (WordPress)
GNU General Public License v2.0
46 stars 17 forks source link

apparent plugin conflict with revslider #3

Closed raifster closed 10 years ago

raifster commented 10 years ago

Dear Khromov,

Thank you for the excellent work on this handy plugin!

I am using WPML 2.93 + revslider 3.08. When I enable wp-wpml-geoip-browser-language-redirect revslider stops working in all browsers I have tested (produces grey box instead of slideshow). When I disable wp-wpml-geoip-browser-language-redirect revslider works again.

Happy to grant you access for troubleshooting if required.

Cheers, Ralph

khromov commented 10 years ago

Hey raif,

Can you send me credentials to your site in a PM, and I'll check it out.

raifster commented 10 years ago

Hey Khromov,

Not sure how to PM you are there are no details on the left of your profile where I would expect to see your email address (I guess you chose to hide this info). Apologies if this is a stupid question but I am new to Github.

Thanks, r:)

khromov commented 10 years ago

Hey,

You can email me here: stanislav -at- khromov -dot- se

raifster commented 10 years ago

Thanks - done!

raifster commented 10 years ago

Dear Stanislav,

Have you received my emails over the last few days? Not sure whether you have as I have not heard from you since I sent them.

Thanks, Raif

khromov commented 10 years ago

Hi Raif,

For some reason it ended up in the Spam inbox, so I didn't see it until now. But I got it!

khromov commented 10 years ago

Hey Ralph, here is the info regarding this info which I also sent to you by mail:

You have two missing commas in the language mapping array. This causes the AJAX call to flip out due to a PHP error, which disables additional JavaScript on the page, thus making the slider not work. I went ahead and added the commas for you.

To verify that everything works properly, you can visit this URL, which should return no error messages: http://www.beachyheads.co.za/?wpml_geoip=1

A few notes on usage of the plugin:

The languages mappings need to match the language codes you have added under WPML > Theme and plugins localization.

So for you the available languages would be: en, aus, mex, uae, usa

And a mapping would look like this:

'MX' => 'mex', //Mexico

(MaxMind GeoIP Code -> WPML code)

If there is no translation available on the first landing page, no redirect will ever occur. The language detection runs the on the first page load only, which means if the user starts on a page that has no translations and then navigates to a page that has a translation, no redirection will occur. This is to avoid user confusion/annoyance.

The way to make this work perfectly is:

I have tested the language redirect and it works fine in Firefox, Chrome and IE. There are some reports of WPML 3.1 not working with this plugin, but you are running 2.9.3 so you should be fine for now.

Closing this issue.

khromov commented 10 years ago

Just to follow up, I have tested the plugin in WPML 3.1.4 and it works as well.

raifster commented 10 years ago

All good now. Thank you khromov!