search

khsing / laravel-world

provide countries, states, and cities relations and database.
MIT License
424 stars 89 forks source link

The error code for the world_divisions #26

Open AnsonOHE opened 4 years ago

AnsonOHE commented 4 years ago

Hello, thanks for sharing the library. As check from the world_division, there is a small error between the code for these 2 rows of record, which is country_id = 87, name = "Pahang" and "Pulau Pinang", as found the code is not correct, it should be "ph" for "Pahang" and "pg" for "Pulau Pinang", kindly please update it. Thanks :) As checked from the web, it is recommended to put the code to "png" for the "Pulau Pinang" rather than only "pg", same for others with the country_id = 87.

khsing commented 3 years ago

@AnsonOHE according to this wiki: https://en.wikipedia.org/wiki/ISO_3166-2:MY, I think it better way to update code with numbers.